Skip to content

Amd/dev/catmoore/pal7 (#1670) to rel-7.2 #1697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jharryma merged 2 commits into from
Dec 1, 2025
Merged

Amd/dev/catmoore/pal7 (#1670) to rel-7.2 #1697

jharryma merged 2 commits into from
Dec 1, 2025

Conversation

@ronlieb
Copy link
Contributor

@ronlieb ronlieb commented Nov 22, 2025 

Amd/dev/catmoore/pal7 (#1670)

* Remove SimpleTimer.h due to invalid license.
Recode use of timer routines using <chrono> in tsp.cpp.

* 1. Remove counting_iterator.h due to licensing issues
2. Update Makefile to use c++-20
3. Remove counting_iterator references in call to transform_reduce

@CatherineMoore @ronlieb
Amd/dev/catmoore/pal7 (#1670)
2ed0804 
* Remove SimpleTimer.h due to invalid license.
Recode use of timer routines using <chrono> in tsp.cpp.

* 1. Remove counting_iterator.h due to licensing issues
2. Update Makefile to use c++-20
3. Remove counting_iterator references in call to transform_reduce
@ronlieb ronlieb requested a review from zGoldthorpe November 28, 2025 22:59
@ronlieb ronlieb requested a review from zGoldthorpe November 28, 2025 23:10
gregrodgers
gregrodgers approved these changes Nov 29, 2025
View reviewed changes
Copy link
Contributor

@gregrodgers gregrodgers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jharryma jharryma merged commit e534b58 into release/rocm-rel-7.2 Dec 1, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gregrodgers gregrodgers gregrodgers approved these changes

@zGoldthorpe zGoldthorpe zGoldthorpe approved these changes

@CatherineMoore CatherineMoore CatherineMoore approved these changes

@carlobertolli carlobertolli Awaiting requested review from carlobertolli

@dpalermo dpalermo Awaiting requested review from dpalermo

@estewart08 estewart08 Awaiting requested review from estewart08 estewart08 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ronlieb @gregrodgers @zGoldthorpe @CatherineMoore @jharryma