Skip to content

Conversation

@illsilin
Copy link
Collaborator

@illsilin illsilin commented Dec 19, 2025

Proposed changes

This fix will allow us to avoid compilation errors like:

[2025-12-10T05:58:58.525Z] /var/jenkins/workspace/LLIBS_composable_kernel_aick-468/include/ck_tile/core/algorithm/coordinate_transform.hpp:844:73: error: reference to host function '' in host device function
[2025-12-10T05:58:58.525Z] 844 | up_lengths_scan_{container_reverse_exclusive_scan(up_lengths, multiplies{}, number<1>{})}
[2025-12-10T05:58:58.525Z] | ^

with the latest mainline and staging compilers.

This will look up the value of the LLVM_MAIN_REVISION macro from the compiler's config.h header and either enable or disable the "host device" attributes.

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

@illsilin
Copy link
Collaborator Author

This workaround is not going to work for AITER or other libs that don't use cmake, but it should work for stand-alone CK builds for the time being, until we get the root-cause fixed in the math.hpp header.

@illsilin illsilin merged commit 2d9c962 into develop Dec 19, 2025
25 checks passed
@illsilin illsilin deleted the aick-481 branch December 19, 2025 22:57
illsilin added a commit that referenced this pull request Dec 20, 2025
illsilin added a commit that referenced this pull request Dec 20, 2025
@valarLip valarLip mentioned this pull request Dec 21, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants