Skip to content

[CK_Builder] Updated README, adressed review comments from PR3459 #3526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kabrahamAMD wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[CK_Builder] Updated README, adressed review comments from PR3459 #3526

kabrahamAMD wants to merge 2 commits into from

Conversation

@kabrahamAMD
Copy link
Contributor

@kabrahamAMD kabrahamAMD commented Jan 7, 2026 •
edited
Loading

Addressed review comments from PR3459, and updated README.

During PR3459, there were two comments, which are addressed here:

  • moved all constraints not used externally to detail namespace
  • added check for ElementwiseOpWellDefinedIfProvided to ConvSignatureDescriptor

Also, while reviewing the latter I realized the README needs updating, which was also done

@kabrahamAMD kabrahamAMD changed the title [Draft] [CK_Builder] Updated README, adressed review comments from PR3459 [CK_Builder] Updated README, adressed review comments from PR3459 Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shumway shumway shumway approved these changes

@Snektron Snektron Snektron approved these changes

@illsilin illsilin Awaiting requested review from illsilin illsilin is a code owner

@carlushuang carlushuang Awaiting requested review from carlushuang carlushuang is a code owner

@qianfengz qianfengz Awaiting requested review from qianfengz qianfengz is a code owner

@aosewski aosewski Awaiting requested review from aosewski aosewski is a code owner

@poyenc poyenc Awaiting requested review from poyenc poyenc is a code owner

@geyyer geyyer Awaiting requested review from geyyer geyyer is a code owner

@bartekxk bartekxk Awaiting requested review from bartekxk bartekxk is a code owner

@andriy-ca andriy-ca Awaiting requested review from andriy-ca andriy-ca is a code owner

@afagaj afagaj Awaiting requested review from afagaj afagaj is a code owner

@asleepzzz asleepzzz Awaiting requested review from asleepzzz asleepzzz is a code owner

@ThomasNing ThomasNing Awaiting requested review from ThomasNing ThomasNing is a code owner

@coderfeli coderfeli Awaiting requested review from coderfeli coderfeli is a code owner

@cgmillette cgmillette Awaiting requested review from cgmillette cgmillette is a code owner

@vidyasagar-amd vidyasagar-amd Awaiting requested review from vidyasagar-amd vidyasagar-amd is a code owner

@ddembeckAMD ddembeckAMD Awaiting requested review from ddembeckAMD ddembeckAMD is a code owner

@tenpercent tenpercent Awaiting requested review from tenpercent tenpercent is a code owner

Assignees

No one assigned

Labels

organization: streamhpc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kabrahamAMD @shumway @Snektron @kabraham-streamhpc