[ROCm-Profiler] Add lds stall preset#211
Open
diptorupd wants to merge 2 commits intoROCm:amd-integrationfrom
Open
[ROCm-Profiler] Add lds stall preset#211diptorupd wants to merge 2 commits intoROCm:amd-integrationfrom
diptorupd wants to merge 2 commits intoROCm:amd-integrationfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new ROCm profiler counter preset aimed at diagnosing LDS/VMEM stall behavior, and introduces automatic derived stall-metric reporting when the required PMCs are present in the collected counter CSVs.
Changes:
- Added a new
lds_stall3-pass rocprofv3 preset to capture LDS/VMEM stall + latency counters under gfx942 constraints. - Added automatic post-processing to print an LDS/VMEM stall analysis table when stall counters are detected.
- Updated the FA2 prefill ROCm benchmark documentation to include the new preset and the derived metrics it prints.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| rocm_profiler/rocm_profiler.py | Adds lds_stall preset and implements stall table detection + printing after profiling. |
| benchmarks/rocm_benchmarks/bench_fa2_prefill.py | Documents the new lds_stall preset and its derived metrics in the usage header. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
demandal25
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds one more preset to the rocm_profiler to capture LDS stall cycles.