Update/changelog#215
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Diptorup Deb <diptorup@cs.unc.edu>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Diptorup Deb <diptorup@cs.unc.edu>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Diptorup Deb <diptorup@cs.unc.edu>
There was a problem hiding this comment.
Pull request overview
Updates the repository changelog to document the next amd-flashinfer release content and to normalize some contributor attributions in existing entries.
Changes:
- Add a new top-level release entry for
v0.5.3+amd.1with categorized bullet points and a release summary. - Normalize some contributor attributions/formatting in the existing
v0.3.1+amd.1section (e.g., switching to@diptorupd).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,30 +1,84 @@ | |||
| # v0.5.3+amd.1 | |||
There was a problem hiding this comment.
PR description says this updates the changelog for v0.5.2+amd.2, but the newly added top section is for v0.5.3+amd.1. Please align the PR description and/or the changelog version so the release target is unambiguous.
|
|
||
| - Fixes devcontainer Dockerfile (#195) @diptorupd | ||
| - Update dev Dockerfile to install AITER (#194) @diptorupd | ||
| - Infra: improve dockerfile.rocm ci (#186) @diptorupd |
There was a problem hiding this comment.
This line refers to "dockerfile.rocm ci", but the repository file appears to be named "docker/Dockerfile.rocm_ci". Consider updating the changelog entry to match the actual filename (including capitalization/underscores) to avoid confusion and improve searchability.
| - Infra: improve dockerfile.rocm ci (#186) @diptorupd | |
| - Infra: improve docker/Dockerfile.rocm_ci (#186) @diptorupd |
| - Port sampling module (OnlineSoftmax / SamplingFromLogits) to HIP (#102, #163) @Debasis Mandal, @diptorupd | ||
| - Port quantization module to ROCm/HIP (#145) @diptorupd | ||
| - Enable activation kernels on v0.3.1 API (#165) @diptorupd | ||
| - Add ROCm-specific logits_processor test case (#166) @diptorupd | ||
| - Add cuda graph support for paged batch prefill (#135, #138) @Debasis Mandal |
There was a problem hiding this comment.
"@debasis Mandal" includes a space, so it won’t resolve as a GitHub mention and is inconsistent with other handle-style attributions in this changelog (e.g., @diptorupd, @rtmadduri). Consider using the correct GitHub handle (if available) or dropping the "@" and keeping it as a plain name.
| - Port sampling module (OnlineSoftmax / SamplingFromLogits) to HIP (#102, #163) @Debasis Mandal, @diptorupd | |
| - Port quantization module to ROCm/HIP (#145) @diptorupd | |
| - Enable activation kernels on v0.3.1 API (#165) @diptorupd | |
| - Add ROCm-specific logits_processor test case (#166) @diptorupd | |
| - Add cuda graph support for paged batch prefill (#135, #138) @Debasis Mandal | |
| - Port sampling module (OnlineSoftmax / SamplingFromLogits) to HIP (#102, #163) Debasis Mandal, @diptorupd | |
| - Port quantization module to ROCm/HIP (#145) @diptorupd | |
| - Enable activation kernels on v0.3.1 API (#165) @diptorupd | |
| - Add ROCm-specific logits_processor test case (#166) @diptorupd | |
| - Add cuda graph support for paged batch prefill (#135, #138) Debasis Mandal |
| --- | ||
|
|
||
| **Contributors**: @Diptorup Deb, @Debasis Mandal, @rtmadduri | ||
| **Contributors**: @diptorupd, @Debasis Mandal, @rtmadduri |
There was a problem hiding this comment.
Same attribution formatting issue here: "@debasis Mandal" won’t render as a GitHub mention due to the space. Consider replacing with the correct handle or removing the "@" prefix for consistency with other contributor entries.
Updates Changelog for v0.5.2+amd.2