Skip to content

Comments

EXSWHTEC-83 - Implement new and reimplement existing tests for hipMemAdvise#3003

Open
music-dino wants to merge 44 commits intoROCm:develop_oldfrom
mirza-halilcevic:hipMemAdvise_tests
Open

EXSWHTEC-83 - Implement new and reimplement existing tests for hipMemAdvise#3003
music-dino wants to merge 44 commits intoROCm:develop_oldfrom
mirza-halilcevic:hipMemAdvise_tests

Conversation

@music-dino
Copy link
Contributor

@music-dino music-dino commented Oct 17, 2022 •
edited
Loading

  • Negative parameter tests
  • Validate that setting and resetting of flags works as expected
  • Validate that setting one flag does not lead to the resetting of another
  • Validate round down for base address and roundup for base address + count behavior
  • Validate that memory can still be read and write after applying each advice
  • Validate that prefetching after setting flags does not interfere with them.

music-dino and others added 30 commits September 30, 2022 02:38
@music-dino
Cit -m RAII guards for memory allocations and streams, define some co…
41844f2 
…mmonly useful utility functions and kernels
@music-dino
Implement helper function for generating allocation flags
858da0e
@music-dino
Implement helper function DeviceAttributesSupport to check if a devic…
899b91f 
…e supports any number of attributes
@music-dino
EXSWHTEC-83 - Implement new and reimplement existing tests for hipMem…
736eff8 
…Advise
@music-dino
EXSWHTEC-83 - Correct bug in Flags_Do_Not_Cause_Prefetch, and minor c…
5a1878c 
…ode corectness touchups
@music-dino
EXSWHTEC-83 - Implement additional negative parameter tests
56b5982
@music-dino
Add error check after launching delay kernel
8a0e740
@music-dino
Merge remote-tracking branch 'origin/utils' into hipMemAdvise_tests
8ddd164
@music-dino
EXSWHTEC-94 - Implement helper classes and functions for memory tests
e534d2e
@music-dino
EXSWHTEC-94 - Remove c++14 standard constraint on memory tests
09ce86a
@music-dino
Merge branch 'utils' into hipMemAdvise_tests
12627cf
@music-dino
EXSWHTEC-94 - Remove GenerateLinearAllocationFlagCombinations until f…
48b337f 
…inished
@music-dino
Merge branch 'develop' into utils
2d3b7a7
@music-dino @mangupta
EXSWHTEC-94 - Implement helper classes and functions for memory tests
715cf30
@music-dino @mangupta
EXSWHTEC-94 - Remove c++14 standard constraint on memory tests
a74fe21
@music-dino @mangupta
EXSWHTEC-94 - Remove GenerateLinearAllocationFlagCombinations until f…
350958e 
…inished
@music-dino
Merge branch 'develop' into utils
ea6689c
@mirza-halilcevic
Merge remote-tracking branch 'origin/utils' into utils
2a44046
@music-dino @mangupta
EXSWHTEC-94 - Implement helper classes and functions for memory tests
691d00e
@music-dino @mangupta
EXSWHTEC-94 - Remove c++14 standard constraint on memory tests
7bdf52f
@music-dino @mangupta
EXSWHTEC-94 - Remove GenerateLinearAllocationFlagCombinations until f…
1185c39 
…inished
@music-dino
Merge remote-tracking branch 'origin/utils' into utils
8d2e833
@mirza-halilcevic
Merge remote-tracking branch 'origin/utils' into utils
e003c4f
@mirza-halilcevic
EXSWHTEC-94 - Implement resource guards for hipMallocPitch and 3D
8911eb7 
allocations.
@music-dino
Merge remote-tracking branch 'origin/utils' into utils
b1a68bd
@music-dino
EXSWHTEC-94 - Add resource guards for 2D and 3D allocations and utils…
76c8e31 
… for handling pitched memory
@music-dino
Merge remote-tracking branch 'upstream/develop' into utils
35f373e
@music-dino
Merge branch 'utils' into hipMemAdvise_tests
73f5c14
@music-dino
EXSWHTEC-83 - Add return value for default branches in helper functions
a724cb5
@music-dino
Merge remote-tracking branch 'origin/hipMemAdvise_tests' into hipMemA…
fb9db79 
…dvise_tests
chrispaquot
chrispaquot previously approved these changes Oct 27, 2022
View reviewed changes
@music-dino music-dino marked this pull request as ready for review November 2, 2022 11:05
mangupta
mangupta previously approved these changes Nov 3, 2022
View reviewed changes
@mangupta
Copy link
Contributor

mangupta commented Nov 4, 2022

@music-dino : Some tests fail on CI. Details shared separately.

@mangupta mangupta added the pr:needs_updates PR initially approved. But needs rework label Nov 4, 2022
@mangupta mangupta added pr:ready_for_ci PR ready to be tested and removed pr:needs_updates PR initially approved. But needs rework labels Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrispaquot chrispaquot chrispaquot approved these changes

@mangupta mangupta mangupta left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

pr:ready_for_ci PR ready to be tested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@music-dino @mangupta @chrispaquot @mirza-halilcevic