device-libs: Replace f32 pred implementation #886
Conversation
This version is more straightforward and relies less on bithacking. It generates an equivalent instruction count and code size. It does increase the vgpr use from 2 to 3. With -ffinite-only, this saves an instruction. This also fixes a bug with the value 0x1p-149f. The old implementation returned -0, instead of +0 as other nextdown implementations do.
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
This version is more straightforward and relies less on bithacking. It generates an equivalent instruction count and code size. It does increase the vgpr use from 2 to 3. With -ffinite-only, this saves an instruction.
This also fixes a bug with the value 0x1p-149f. The old implementation returned -0, instead of +0 as other nextdown implementations do.