[AMDGPU] Remove add/sub combines corrupting carry bit#91
Closed
vosen wants to merge 2 commits intoROCm:amd-stagingfrom
vosen:carry_fix
Closed
[AMDGPU] Remove add/sub combines corrupting carry bit#91vosen wants to merge 2 commits intoROCm:amd-stagingfrom vosen:carry_fix
vosen wants to merge 2 commits intoROCm:amd-stagingfrom
vosen:carry_fix
Conversation
Isel would apply optimizations in the form of uaddo_carry (add x, y), 0, cc => uaddo_carry x, y, cc. This preserves the correct addition result, but not correct cc bit. For large x and y it could set cc = 0 on the lhs and cc = 1 on the rhs
|
@searlmc1 Have you seen this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Isel would apply optimizations in the form of
uaddo_carry (add x, y), 0, cc => uaddo_carry x, y, cc. This preserves the correct addition result, but not correct cc bit. For large x and y it could set cc = 0 on the lhs and cc = 1 on the rhs