Skip to content

Revert "refactor(auth): centralize credential loading and Docker registry login" #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gargrahul merged 1 commit into from
Apr 21, 2026
Merged

Revert "refactor(auth): centralize credential loading and Docker registry login" #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
129 changes: 0 additions & 129 deletions CLAUDE.md
View file
Open in desktop

This file was deleted.

2 changes: 2 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@ dependencies = [
"GitPython",
"jsondiff",
"sqlalchemy",
"setuptools-rust",
"paramiko",
"tqdm",
"pytest",
"typing-extensions",
"pymongo",
"toml",
Expand Down
8 changes: 2 additions & 6 deletions src/madengine/cli/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
"""

import sys
from importlib.metadata import PackageNotFoundError, version as pkg_version

import typer
from rich.traceback import install
Expand Down Expand Up @@ -56,12 +55,9 @@ def main(
Built with Typer and Rich for a beautiful, production-ready experience.
"""
if version:
try:
_version = pkg_version("madengine")
except PackageNotFoundError:
_version = "unknown"
# You might want to get the actual version from your package
console.print(
f"🚀 [bold cyan]madengine[/bold cyan] version [green]{_version}[/green]"
"🚀 [bold cyan]madengine[/bold cyan] version [green]2.0.0[/green]"
)
raise typer.Exit()
Comment on lines 57 to 62
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--version output is now hardcoded to 2.0.0, which will become incorrect as soon as the package version changes and breaks automation that relies on accurate version reporting. Consider restoring runtime version lookup via importlib.metadata.version('madengine') (with a fallback when not installed).

Copilot uses AI. Check for mistakes.

Expand Down
3 changes: 0 additions & 3 deletions src/madengine/cli/commands/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,6 @@ def run(
# Convert -1 (default) to actual default timeout value (7200 seconds = 2 hours)
if timeout == -1:
timeout = 7200
# 0 means "no timeout" per the help text — map to None so subprocess never expires
elif timeout == 0:
timeout = None

Comment on lines 194 to 197
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --timeout option help says 0 means “no timeout”, but the code no longer maps timeout == 0 to None. With the current Console.sh implementation, a timeout of 0 seconds will immediately raise TimeoutExpired. Restore the 0 -> None mapping (or treat 0 as a large sentinel) to match the CLI contract.

Copilot uses AI. Check for mistakes.
try:
# Check if we're doing execution-only or full workflow
Expand Down
6 changes: 2 additions & 4 deletions src/madengine/cli/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,11 @@
Copyright (c) Advanced Micro Devices, Inc. All rights reserved.
"""

from enum import IntEnum


# Exit codes
class ExitCode(IntEnum):
class ExitCode:
"""Exit codes for CLI commands."""

SUCCESS = 0
FAILURE = 1
BUILD_FAILURE = 2
Expand Down
2 changes: 0 additions & 2 deletions src/madengine/cli/validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,8 +395,6 @@ def process_batch_manifest_entries(

# If the model was not built (build_new=false), create an entry for it
if not build_new:
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dockerfile_matched was previously initialized before the try, but it’s still referenced later in the except fallback path (synthetic_image_name = f"ci-{model_name}_{dockerfile_matched}"). If an exception occurs before dockerfile_matched is assigned, this will raise UnboundLocalError and skip creating the minimal entry. Reintroduce a safe initialization (e.g., dockerfile_matched = 'unknown') before the try.

Suggested change
if not build_new:
if not build_new:
# Default value used by the fallback path if discovery fails early.
dockerfile_matched = "unknown"

Copilot uses AI. Check for mistakes.
# Initialize with a safe fallback so the except block can always reference it
dockerfile_matched = "unknown"
# Find the model configuration by discovering models with this tag
try:
# Create a temporary args object to discover the model
Expand Down
178 changes: 0 additions & 178 deletions src/madengine/core/auth.py
View file
Open in desktop

This file was deleted.

Loading