[IFC] Indirect functions with split compile and link over types and optional generic mode #2115
+1,054
−167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doru1004
force-pushed
the
indirect-functions-with-link-speedup-and-optional-generic
branch
2 times, most recently
from
385a303 to
32443aa
Compare
Contributor
|
I think my main comment is that there are many changes in files that we have inherited from NCCL. If there is any way to put most of these changes in new files, I think that would help make future code syncs with NCCL simpler. |
Improve link time by splitting over types Create separate compilation units and commands for each type. Split across types and unroll factor.
doru1004
force-pushed
the
indirect-functions-with-link-speedup-and-optional-generic
branch
from
32443aa to
c56107c
Compare
mustafabar
reviewed
Jan 6, 2026
| #endif // BUILD_GENERIC_KERNELS | ||
|
|
||
| // Type-specific kernel declarations | ||
| __global__ void ncclDevKernel_i8_1(ncclDevKernelArgs4K NCCL_GRID_CONSTANT const args4K); |
Contributor
There was a problem hiding this comment.
need to use ncclDevKernelArgsDefaultStorage instead of ncclDevKernelArgs4K
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Do not mention proprietary info or link to internal work items in this PR.
Work item: "Internal", or link to GitHub issue (if applicable).
What were the changes?
One sentence describing the work done.
Why were the changes made?
Explain the motivation behind the work. Provide any publicly-available historical context.
How was the outcome achieved?
Technical details behind the work. Explain any publicly-available hardware peculiarities.
Additional Documentation:
What else should the reviewer know?
Approval Checklist
Do not approve until these items are satisfied.