rocAL Serialize PR 4 : Pipeline serialization support#410
Merged
rrawther merged 134 commits intoROCm:developfrom Dec 16, 2025
Merged
rocAL Serialize PR 4 : Pipeline serialization support#410rrawther merged 134 commits intoROCm:developfrom
rrawther merged 134 commits intoROCm:developfrom
Conversation
Remove the usage of API enums in internal node files
Add support to register all internal enums
Creates an argument instance for each arg passed in the Node Handles different argument types i.e parameters, vectors, enums and predefined types
…and ImageLoaderNode
Add support to serialize the args and pipeline details Add support to serialize the tensors.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Create single constructor with check for different data types in Argument class
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This reverts commit 72ff657.
rrawther
reviewed
Dec 4, 2025
rrawther
requested changes
Dec 5, 2025
Collaborator
rrawther
left a comment
rrawther
left a comment
There was a problem hiding this comment.
please address the review comments
Contributor
|
@fiona-gladwin please resolve conflicts |
Contributor
Author
|
@rrawther Addressed all comments. Please check and let me know if I need to make any further changes |
LakshmiKumar23
previously approved these changes
Dec 10, 2025
rrawther
previously approved these changes
Dec 15, 2025
LakshmiKumar23
previously approved these changes
Dec 15, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #410 +/- ##
===========================================
- Coverage 80.64% 79.90% -0.74%
===========================================
Files 279 281 +2
Lines 21288 21491 +203
===========================================
+ Hits 17167 17172 +5
- Misses 4121 4319 +198
🚀 New features to boost your workflow:
|
fiona-gladwin
dismissed stale reviews from LakshmiKumar23 and rrawther
via
4ecb3ee
LakshmiKumar23
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR implements pipeline serialization functionality for rocAL, enabling pipelines to be serialized to protobuf format for persistence and portability.
Technical Details
Test Plan
No new tests added. Must pass existing tests
NOTE : To be merged after PR #401