rocAL Unit test fix#427
Merged
kiritigowda merged 14 commits intoROCm:developfrom Jan 6, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes unit test failures in the rocAL Python and C++ APIs by correcting data paths, API parameters, and test output names to align with the current implementation.
Key changes:
- Enhanced lens correction API to accept both single parameters (replicated across batch) and per-image parameters
- Fixed web dataset reader configuration with correct file extensions and API parameters
- Corrected test output names for better clarity
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/python_api/unit_tests.sh | Updated web dataset path to include tar_file subdirectory |
| tests/python_api/unit_test.py | Fixed web dataset reader parameters, added missing vignette parameter, and updated lens correction to use camera matrix and distortion coefficients |
| tests/cpp_api/unit_tests/testAllScripts.sh | Corrected test output names to include "Random" suffix and added missing ResizeMirrorNormalize test |
| rocAL_pybind/amd/rocal/fn.py | Enhanced lens_correction function to handle both single and per-image parameter configurations |
| rocAL/source/augmentations/geometry_augmentations/node_lens_correction.cpp | Implemented parameter replication logic for single camera matrix and distortion coefficients |
| rocAL/source/api/rocal_api_augmentation.cpp | Updated validation to allow size of 1 for camera matrix and distortion coefficients with improved error messages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
LakshmiKumar23
approved these changes
Dec 16, 2025
rrawther
requested changes
Jan 2, 2026
rrawther
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes unit tests for the Python API by correcting data paths, API parameters, and test names to align with updated functionality.
Technical Details
Test Plan
Test Result
rocAL C++ and python unit test :
Submission Checklist