[hipfft-test] add omitted references in catch blocks in hipfftw tests #3662
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evetsso
approved these changes
Jan 6, 2026
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #3662 +/- ##
============================================
- Coverage 82.04% 56.18% -25.85%
============================================
Files 476 14 -462
Lines 34629 3980 -30649
Branches 0 595 +595
============================================
- Hits 28408 2236 -26172
+ Misses 6221 1487 -4734
- Partials 0 257 +257
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
eng-flavio-teixeira
approved these changes
Jan 6, 2026
assistant-librarian bot
pushed a commit
to ROCm/hipFFT
that referenced
this pull request
Jan 7, 2026
[hipfft-test] add omitted references in catch blocks in hipfftw tests (#3662) ## Motivation Self-explanatory title (omissions in original implementations). ## Technical Details Self-explanatory. ## Test Plan Current tests suffice. ## Test Result Tests pass. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Self-explanatory title (omissions in original implementations).
Technical Details
Self-explanatory.
Test Plan
Current tests suffice.
Test Result
Tests pass.
Submission Checklist