Continuous deployment #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're adding functionality to build a single script in isolation, we changed the `del` plugin to only remove the built files for the script which is currently being built. This is unnecessary, since they'll be overwritten anyway.
Changing the previous CD setup to remove the requirement to manually bump the version whenever a release needs to be made. `commit_release` will now compare the previously built version to a built version of the most recent code. When any change is detected to the built code, it will automatically increment the version and commit the new version to `dist`, as before.
We were previously deploying on any push to `main`. Since we won't directly push to `main`, we can instead run the deployments after PRs are merged. This will allow us to leave a comment on the PR after the deployment is done, or if it has somehow failed.
ROpdebee
force-pushed
the
continuous-deployment
branch
from
7566adb to
afcfcd5
Compare
This was referenced Oct 17, 2021
ROpdebee
force-pushed
the
continuous-deployment
branch
from
d6de368 to
832bc68
Compare
ROpdebee
force-pushed
the
continuous-deployment
branch
from
832bc68 to
5ebc3e4
Compare
Codecov Report
@@ Coverage Diff @@
## main #84 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 27
Lines ? 481
Branches ? 84
========================================
Hits ? 481
Misses ? 0
Partials ? 0 Continue to review full report at Codecov.
|
We'll be using those files to create dynamic install badges.
Owner
Author
|
Merging this without review because it's blocking some other PRs and the easiest way to make sure it's working properly is to actually push it :) Apologies! Feel free to leave any remarks and I'll do the fixes afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally intended to only enable CD after E2E tests were added, but since there's now 2 PRs open which could both be released as a new version and I didn't want to run into conflicts by bumping the version in both PRs separately, I'm adding it now.
Quick summary of the changes:
meta.tsfiles don't contain versions anymore.main. That scheduled workflow will also create an issue if it fails (at most one issue will be open at any given time, if a run fails and an issue already exists and is open, the existing issue will be edited).npm run buildandnpm run build-devnow generate a version themselves, but this should only really be used for local development usage or in CI to check that the scripts can be built correctly.