Skip to content

Conversation

@chaban-mb
Copy link
Contributor

As described in the forum, Spotify is messing with the Open Graph tags. Apparently simply omitting the User-Agent header fixes this problem.

Copy link
Owner

@ROpdebee ROpdebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looking good, just some minor issues that CI is complaining about :)

Note to self: We also need to re-generate the saved HTTP responses for the Spotify tests then.

@chaban-mb
Copy link
Contributor Author

This is my second ever pull request and I never used git and stuff before. So please bear with me if I mess this up. :)

@chaban-mb chaban-mb requested a review from ROpdebee October 3, 2025 23:42
Copy link
Owner

@ROpdebee ROpdebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, we all had to start somewhere! 😄 And you didn't mess anything up! 👍

Changes are looking good, it's a shame about having to use an empty string instead of null but if it works, it works 🤷 I looked into it and while it would be possible to change the type definitions to allow null there, it would then lead to type errors in our network request implementation., so I'd prefer to keep it properly typed if possible.

@ROpdebee ROpdebee merged commit b7534f2 into ROpdebee:main Oct 6, 2025
11 checks passed
github-actions bot added a commit that referenced this pull request Oct 6, 2025
fix(spotify): remove User-Agent header (#850)
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

🚀 Released 1 new userscript version(s):

  • mb_enhanced_cover_art_uploads 2025.10.6 in a631f5f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants