-
Notifications
You must be signed in to change notification settings - Fork 13
fix(spotify): remove User-Agent header #850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ROpdebee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looking good, just some minor issues that CI is complaining about :)
Note to self: We also need to re-generate the saved HTTP responses for the Spotify tests then.
|
This is my second ever pull request and I never used git and stuff before. So please bear with me if I mess this up. :) |
ROpdebee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, we all had to start somewhere! 😄 And you didn't mess anything up! 👍
Changes are looking good, it's a shame about having to use an empty string instead of null but if it works, it works 🤷 I looked into it and while it would be possible to change the type definitions to allow null there, it would then lead to type errors in our network request implementation., so I'd prefer to keep it properly typed if possible.
fix(spotify): remove User-Agent header (#850)
|
🚀 Released 1 new userscript version(s):
|
As described in the forum, Spotify is messing with the Open Graph tags. Apparently simply omitting the User-Agent header fixes this problem.