Add log4j-core to the classpath#450
Merged
cwisniew merged 3 commits intoRPTools:developfrom Apr 16, 2025
Merged
Conversation
Without this, app init fails with NoSuchMethodError related to loading Sentry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #449
Adding log4j-core as an implementation dependency makes the version match (2.19 instead of 2.17) and allows log4j to properly load.
I also noticed spotless has been disabled for a long time now, but it doesn't look like that needs to be the case. So I reenabled it, hence the handful of formatting changes.
Also updated the
verify-buildworkflow to useactions/cache@v4as the old version is not fully compatible with the new cache service (see the recommendation on that project).This change is