[bsp][zynqmp-a53-dfzu2eg] enable full dm#11239
[bsp][zynqmp-a53-dfzu2eg] enable full dm#11239GuEe-GUI wants to merge 1 commit intoRT-Thread:masterfrom
Conversation
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
📌 Code Review Assignment🏷️ Tag: componentsReviewers: Maihuanyi Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2026-03-09 20:29 CST)
📝 Review Instructions
|
There was a problem hiding this comment.
Pull request overview
This PR updates the zynqmp-a53-dfzu2eg BSP toward a “full DM” (device model) configuration by switching to OFW/FDT-based hardware description and adding DM-style UART/RTC drivers for ZynqMP, along with the build/config changes needed to support the new flow.
Changes:
- Add a ZynqMP device tree (
zynqmp.dts) and build it into a DTB during BSP build. - Enable DM/OFW/builtin-FDT in BSP config and hook up new DM drivers (Cadence/Xilinx UARTPS + ZynqMP RTC).
- Remove legacy non-DM BSP driver headers/implementations and simplify board init to
rt_hw_common_setup().
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| libcpu/aarch64/common/SConscript | Adds a DTB dependency hook for builtin FDT object. |
| components/drivers/include/dt-bindings/interrupt-controller/irq.h | Adds IRQ trigger type bindings for DTS usage. |
| components/drivers/include/dt-bindings/interrupt-controller/arm-gic.h | Adds ARM GIC bindings for DTS usage. |
| bsp/zynqmp-a53-dfzu2eg/zynqmp.dts | New device tree describing memory/cpus/timer/GIC/uart/rtc. |
| bsp/zynqmp-a53-dfzu2eg/SConstruct | Invokes dtc.dts_to_dtb() to generate zynqmp.dtb. |
| bsp/zynqmp-a53-dfzu2eg/drivers/serial/xilinx_uartps.c | New DM serial driver (Cadence/Xilinx UARTPS) + earlycon support. |
| bsp/zynqmp-a53-dfzu2eg/drivers/rtc/rtc-zynqmp.c | New DM RTC driver for ZynqMP RTC + alarm support. |
| bsp/zynqmp-a53-dfzu2eg/drivers/SConscript | Builds the new serial/rtc drivers based on config. |
| bsp/zynqmp-a53-dfzu2eg/drivers/serial/Kconfig | Adds Kconfig symbol for the UARTPS driver. |
| bsp/zynqmp-a53-dfzu2eg/drivers/rtc/Kconfig | Adds Kconfig symbol for the ZynqMP RTC driver. |
| bsp/zynqmp-a53-dfzu2eg/rtconfig.h | Enables DM/OFW/builtin-FDT and updates BSP feature selections. |
| bsp/zynqmp-a53-dfzu2eg/Kconfig | Updates SoC selects, but removes prior BSP drivers Kconfig inclusion. |
| bsp/zynqmp-a53-dfzu2eg/qemu.py | Adds a QEMU launch helper script for the BSP. |
| bsp/zynqmp-a53-dfzu2eg/drivers/board.c | Simplifies board init to rt_hw_common_setup(). |
| bsp/zynqmp-a53-dfzu2eg/README.md | Updates boot command and driver support table (adds RTC). |
| bsp/zynqmp-a53-dfzu2eg/.config | Enables DM/OFW/builtin-FDT, UARTPS, RTC/alarm, memblock, etc. |
Comments suppressed due to low confidence (1)
bsp/zynqmp-a53-dfzu2eg/Kconfig:24
- [bug/类别: bug]: BSP-local driver Kconfig files are not sourced
English: This BSP adds drivers/serial/Kconfig and drivers/rtc/Kconfig, but the top-level BSP Kconfig does not source/rsource them (and the old source "$(BSP_DIR)/drivers/Kconfig" was removed). As a result, symbols like RT_SERIAL_XILINX_PS / RT_RTC_ZYNQMP may be undefined in menuconfig and .config loading can break.
中文:该 BSP 新增了 drivers/serial/Kconfig 和 drivers/rtc/Kconfig,但 BSP 顶层 Kconfig 没有通过 source/rsource 引入它们(且原来的 source "$(BSP_DIR)/drivers/Kconfig" 已被移除)。这样会导致 RT_SERIAL_XILINX_PS / RT_RTC_ZYNQMP 等符号在 menuconfig 中未定义,读取/生成 .config 可能失败。
SOC_DM_RTC_DIR := $(BSP_DIR)/drivers/rtc
SOC_DM_SERIAL_DIR := $(BSP_DIR)/drivers/serial
source "$(RTT_DIR)/Kconfig"
osource "$PKGS_DIR/Kconfig"
config SOC_ZYNQMP_AARCH64
bool
select ARCH_ARMV8
select RT_USING_COMPONENTS_INIT
select RT_USING_USER_MAIN
select ARCH_CPU_64BIT
select RT_USING_CACHE
select RT_USING_STDC_ATOMIC
default y
c7c0da7 to
08ebb85
Compare
This is a builtin fdt example BSP Signed-off-by: GuEe-GUI <2991707448@qq.com>
08ebb85 to
ab6fcf0
Compare
拉取/合并请求描述:(PR description)
[
This is a builtin fdt example BSP
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up