Merged
Conversation
SimonRit
force-pushed
the
remove_motion_compensated
branch
from
6b23238 to
612f33c
Compare
Collaborator
|
@cyrilmory Please validate the latest version. |
Contributor
Author
|
Looks good to me |
SimonRit
force-pushed
the
remove_motion_compensated
branch
from
612f33c to
f101390
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the motion compensated applications and filters:
The rationale for this removal is that apparently, these filters and applications have been unused for 10 years, and a bug has recently been discovered in MC ROOSTER that might take a lot of effort to fix.
At the moment, the underlying filters, which do seem to work as expected, have not been removed. Those are :
Warped projectors and filters built on top of those :
rtkCudaWarpBackProjectionImageFilterrtkCudaWarpForwardProjectionImageFilterrtkWarpFourDToProjectionStackImageFilter
rtkWarpProjectionStackToFourDImageFilter
Warping operators (deformation only, no forward or back projection involved) :
rtkCudaWarpImageFilterrtkCudaForwardWarpImageFilterrtkForwardWarpImageFilterrtkUnwarpSequenceConjugateGradientOperatorrtkUnwarpSequenceImageFilterrtkWarpSequenceImageFilterWould you like (some of) them removed too ? Only two of them