Skip to content

Integrate AHU and simplified, inert transfer systems into ROM #1607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
HoeppJ wants to merge 88 commits into
base: main
Choose a base branch
from
Open

Integrate AHU and simplified, inert transfer systems into ROM #1607

HoeppJ wants to merge 88 commits into from

Conversation

@HoeppJ
Copy link
Contributor

@HoeppJ HoeppJ commented Sep 9, 2025

This pull request targets bug fixes in new modular AHU - merged into main in #834 - (Issue #1586), integrating the new modular AHU in ROM (Issue #1579) and adding an simplified approach to integrate inert heat/cool transfer system behavior into ROM (Issues #1572)

DaJansenGit and others added 30 commits January 16, 2025 17:20
@DaJansenGit
add simplified heat transfer systems for ROM
f44a061
@DaJansenGit
remove obsolete code
1475b83
@DaJansenGit
put all relevant values into record
0b70eb2
@HoeppJ
Added records/parameters for transfer systems
2e69ee2
@HoeppJ
Added records/parameters for transfer systems
9c40808
@DaJansenGit
fix naming for HeaterCoolerPIFraRadDamped.mo
d775b26
@HoeppJ
Update transfer system pt1 parameters
f2b125e
@HoeppJ
Merge remote-tracking branch 'origin/1572-add-simplified-transfer-sys…
38aae3a 
…tem-behavior-to-rom-simulation' into 1572-add-simplified-transfer-system-behavior-to-rom-simulation
@HoeppJ
Update transfer system to set parameters in zone params
fe09e86
@HoeppJ
Update transfer system to set parameters in zone params
c1167c4
@HoeppJ
Delete obsolete
f6a5ef8
@HoeppJ
Delete transfer system enumeration
0ba0583
@HoeppJ
Added dynamic volume flow control per zone depending on room temperat…
bc611aa 
…ure devaition
@HoeppJ
Merge remote-tracking branch 'origin/1572-add-simplified-transfer-sys…
3935e08 
…tem-behavior-to-rom-simulation' into 1572-add-simplified-transfer-system-behavior-to-rom-simulation
@HoeppJ
Added dynamic volume flow control per zone depending on room temperat…
2116a51 
…ure devaition
@HoeppJ
Added parameter for max PI output
a664f57
@HoeppJ
Forther AHU updates
4b4d5ee 
Updated Dynamic Volume Flow control in AHU and added dynamic supply temperature control for AHU
@HoeppJ
Further AHU updates
ded43e8 
Updated Dynamic Volume Flow control in AHU and added dynamic supply temperature control for AHU
@HoeppJ
Merge remote-tracking branch 'origin/1572-add-simplified-transfer-sys…
1572b2a 
…tem-behavior-to-rom-simulation' into 1572-add-simplified-transfer-system-behavior-to-rom-simulation
@HoeppJ
Further ahu updates
987e2c7
@HoeppJ
Further ahu updates
36821fd
@HoeppJ
Further ahu updates
6bd0bdc
@HoeppJ
Update default values
e2dee91
@HoeppJ
differentiate between heating and cooling for pt1 params
b9e12a5
@HoeppJ
Integrated modular ahu in multizone
1721d8b
@HoeppJ
fixed some bugs
7bbed04
@HoeppJ
Merge branch '1586-bug-fixes-in-new-modular-ahu-model' into simplifie…
f3f2e44 
…d_transfer_and_ahu
@HoeppJ
Merge branch '1572-add-simplified-transfer-system-behavior-to-rom-sim…
d50c750 
…ulation' into simplified_transfer_and_ahu
@HoeppJ
Solve merge problems
e836038
@HoeppJ
Add simplified transfer system params to zone records in database
a685734
@ebc-aixlib-bot
Copy link
Contributor

ebc-aixlib-bot commented Dec 9, 2025

Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/AixLib/simplified_transfer_and_ahu/charts

@DaJansenGit
CI message from ebc-aixlib-bot. Automatic push of CI with new regress…
0ab2f3b 
…ion reference files. Please pull the new files before push again. Plottet Results /simplified_transfer_and_ahu/charts/
@ebc-aixlib-bot
Copy link
Contributor

ebc-aixlib-bot commented Dec 9, 2025

Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/AixLib/simplified_transfer_and_ahu/charts

1 similar comment
@ebc-aixlib-bot
Copy link
Contributor

ebc-aixlib-bot commented Dec 9, 2025

Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/AixLib/simplified_transfer_and_ahu/charts

DaJansenGit and others added 3 commits December 9, 2025 09:49
@DaJansenGit
CI message from ebc-aixlib-bot. Automatic push of CI with new regress…
51f5178 
…ion reference files. Please pull the new files before push again. Plottet Results /simplified_transfer_and_ahu/charts/
@HoeppJ
update records
ee4deb1
@HoeppJ
Merge remote-tracking branch 'origin/simplified_transfer_and_ahu' int…
fd881f1 
…o simplified_transfer_and_ahu
@ebc-aixlib-bot
Copy link
Contributor

ebc-aixlib-bot commented Dec 9, 2025

Errors in regression test. Compare the results on the following page
https://rwth-ebc.github.io/AixLib/simplified_transfer_and_ahu/charts

@ebc-aixlib-bot
Copy link
Contributor

ebc-aixlib-bot commented Dec 9, 2025

Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/AixLib/simplified_transfer_and_ahu/charts

@DaJansenGit
CI message from ebc-aixlib-bot. Automatic push of CI with new regress…
e058f06 
…ion reference files. Please pull the new files before push again. Plottet Results /simplified_transfer_and_ahu/charts/
@ebc-aixlib-bot
Copy link
Contributor

ebc-aixlib-bot commented Dec 9, 2025

Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/AixLib/simplified_transfer_and_ahu/charts

@ebc-aixlib-bot
Copy link
Contributor

ebc-aixlib-bot commented Dec 9, 2025

Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/AixLib/simplified_transfer_and_ahu/charts

DaJansenGit and others added 3 commits December 9, 2025 17:10
@DaJansenGit
CI message from ebc-aixlib-bot. Automatic push of CI with new regress…
1f0a796 
…ion reference files. Please pull the new files before push again. Plottet Results /simplified_transfer_and_ahu/charts/
@HoeppJ
add "each" in ahu dynamic controls
4a0f631
@HoeppJ
delete old reference results
e906c55
@ebc-aixlib-bot
Copy link
Contributor

ebc-aixlib-bot commented Dec 12, 2025

Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/AixLib/simplified_transfer_and_ahu/charts

DaJansenGit and others added 5 commits December 12, 2025 15:35
@ebc-aixlib-bot
Copy link
Contributor

ebc-aixlib-bot commented Dec 17, 2025

Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/AixLib/simplified_transfer_and_ahu/charts

@DaJansenGit
CI message from ebc-aixlib-bot. Automatic push of CI with new regress…
f9c2259 
…ion reference files. Please pull the new files before push again. Plottet Results /simplified_transfer_and_ahu/charts/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FWuellhorst FWuellhorst Awaiting requested review from FWuellhorst

@HvanderStok HvanderStok Awaiting requested review from HvanderStok

At least 1 approving review is required to merge this pull request.

Assignees

@HoeppJ HoeppJ

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@HoeppJ @ebc-aixlib-bot @DaJansenGit @FWuellhorst