-
Notifications
You must be signed in to change notification settings - Fork 14
support for lnd v0.9.0 #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/types/rpc/router-rpc.ts
Outdated
| @@ -1,5 +1,6 @@ | |||
| import { HTLCAttempt } from '../generated/rpc_pb'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not import from generated types
src/types/rpc/router-rpc.ts
Outdated
| } | ||
|
|
||
| export interface PaymentStatusUpdate { | ||
| export interface PaymentStatus { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was called PaymentStatusUpdate to avoid changing the PaymentStatus enum name
src/types/rpc/ln-rpc.ts
Outdated
| amt: number; | ||
| chanPoint?: ChannelPoint; | ||
| localKey?: KeyDescriptor; | ||
| remoteKey?: Uint8Array | string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uint8Array | string; -> Buffer | string;
src/types/rpc/ln-rpc.ts
Outdated
| chanPoint?: ChannelPoint; | ||
| localKey?: KeyDescriptor; | ||
| remoteKey?: Uint8Array | string; | ||
| pendingChanId?: Uint8Array | string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uint8Array | string; -> Buffer | string;
src/types/rpc/ln-rpc.ts
Outdated
| useMissionControl?: boolean; | ||
| ignoredPairs?: NodePair[]; | ||
| cltvLimit?: number; | ||
| destCustomRecordsMap?: Array<[number, Uint8Array]> | string[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Array<[number, Uint8Array]> | string[]; -> Array<[number, Buffer]> | string[];
src/types/rpc/router-rpc.ts
Outdated
| cltvLimit?: number; | ||
| routeHints?: RouteHint[]; | ||
| destTlvMap?: Array<[number, Buffer | string]>; | ||
| destCustomRecordsMap?: Array<[number, Uint8Array]> | string[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Array<[number, Uint8Array]> | string[]; -> Array<[number, Buffer]> | string[];
|
The ln-rpc types are missing some new RPC methods & types: |
|
Updated! |
src/types/rpc/ln-rpc.ts
Outdated
| * the client in which any events relevant to the state of peers are sent | ||
| * over. Events include peers going online and offline. | ||
| */ | ||
| subscribePeerEvents(PeerEventSubscription): Promise<PeerEvent>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a streaming method. The return type should be Readable<PeerEvent>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the param should args?: {}
src/types/rpc/ln-rpc.ts
Outdated
| * Alternatively, this can be used to interactively drive PSBT signing for | ||
| * funding for partially complete funding transactions. | ||
| */ | ||
| fundingStateStep(FundingTransitionMsg): Promise<FundingStateStepResp>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Param should be args?: FundingTransitionMsg
|
Remove package-lock.json |
|
Any subscription method names will have to be added to the correct |
|
Good call, I didn't realize that about the streaming methods. Updated with feedback. |
|
Updated with some props that were removed accidentally in previous commits. |
Adds support for lnd v0.9.0