Merged
Conversation
- `documentable update` is still broken due to finanalyst/raku-pod-from-cache/issues/4 Each update test will have to be done in a separate file or some similar hack - `use-cache` option has been deleted, so the use of the cache will be enforced.
Before this change we used "filename" attribute to look for the Primary object updated. The problem is that, that "filename" is, in general: - Not unique, there could be two different pod6 files with the same name, but in different subdirectories. - No canonical. For instance, the filename of a Type is X::Something, instead of X/Something.pod6. To avoid these problems we use an absolute path for each pod6 file, `source-path`. `Pod::From::Cache` returns paths relatives to the working directory of the cache, so they need to be converted to `absolute`.
It always used the default (installed alongside Perl6::TypeGraph)
JJ
reviewed
Jul 18, 2020
| If C<True>, L<Pod::To::Cached|https://github.com/Raku/Pod-To-Cached> will be used | ||
| to load the pods and create a cache (B<recommended>). | ||
|
|
||
| B<Default:> C<True>. |
Contributor
There was a problem hiding this comment.
So the cache will always be used. Please make sure to bump versions accordingly, since it's a change in behavior.
| :$topdir, | ||
| :dirs(DOCUMENTABLE-DIRS), | ||
| :verbose($verbose), | ||
| :$typegraph-file |
Contributor
There was a problem hiding this comment.
This is unrelated to the cache, right?
Collaborator
Author
There was a problem hiding this comment.
Yep, but after fixing the update option that error appeared.
|
|
||
| use Documentable; | ||
| use Pod::Load; | ||
| use Documentable::Config; |
Contributor
There was a problem hiding this comment.
Did you check if it's no longer used to eliminate it from dependencies?
Collaborator
Author
There was a problem hiding this comment.
It's still used in the tests.
| rmtree("t/.cache-test-doc"); | ||
| rmtree("html"); | ||
|
|
||
| done-testing; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.