Merged
Conversation
JJ
approved these changes
Jul 29, 2020
Contributor
JJ
left a comment
JJ
left a comment
There was a problem hiding this comment.
It's good to have, anyway. Thanks!
Collaborator
|
Oh, thanks a lot! I have set up my editor to do this from now on. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some projects consider this a must, and will disallow commits to be submitted which contain trailing whitespace (the Linux kernel is an example project where trailing whitespace isn't permitted). Other projects see whitespace cleanup as simply nit-picking. Either way, I thought I'd bring it to your attention and fix the issue just in case you'd like it to be fixed.
This PR is submitted in the hope that it is useful. If you would like anything changed, please just let me know and I'll be happy to update and resubmit as necessary.