Fix name of template directory

[paultcochrane]

The name of the template directory was changed to templates in
44e524d, which was incorrect as discussed in #120. This commit fixes
issue #120 by using the singular form for this directory name and hence
fixes the test error being seen in t/101-cli.t.

[JJ]

As a change, it's OK, but I think the underlying code should be refactored so that every name and list is in a constant, so that we don't have to change it in many places going forward.

[paultcochrane]

I agree with you wrt refactoring the code. However, should the highlights directory also be checked for existence on line 123 of CLI.pm6? (It probably should be, but I'm not sufficiently experienced with this code to make that call). Also, how to handle the extra Boolean condition for template at the end of line 123 (!"./template".IO.e and $v) which the other variables don't have?

[JJ]

I agree with you wrt refactoring the code. However, should the highlights directory also be checked for existence on line 123 of CLI.pm6? (It probably should be, but I'm not sufficiently experienced with this code to make that call). Also, how to handle the extra Boolean condition for template at the end of line 123 (!"./template".IO.e and $v) which the other variables don't have?

It most probably should...

[paultcochrane]

Unfortunately, I think the Travis tests will still fail (I'm getting test failures about the render method not being found; also when I'm using documentable directly). Nevertheless, the test which was failing on the missing template directory will still pass.

[JJ]

First one is just nitpick, but you should really check the second; the changed code is slightly different. Might be this one is better, which is why I approve; but please check it any way, just in case.

[paultcochrane]

@JJ many thanks for your comments and feedback! It's refreshing to have someone review my patches so closely!

[JJ]

@JJ many thanks for your comments and feedback! It's refreshing to have someone review my patches so closely!

To the point that documentation is mission-critical, this module is an essential part of that mission, so I guess it pays off to check out pull requests. Which, BTW, I really appreciate.

[JJ]

Thanks a lot!