Open
Conversation
Risca
reviewed
Feb 3, 2022
Member
Risca
left a comment
Risca
left a comment
There was a problem hiding this comment.
Apart from the missing headerValues, it looks good to me. Haven't tested building or running it. Just did a quick scan
|
|
||
| ret = MHD_add_response_header(response, MHD_HTTP_HEADER_WWW_AUTHENTICATE, "Basic realm=XBMC"); | ||
| ret |= MHD_add_response_header(response, MHD_HTTP_HEADER_CONNECTION, "close"); | ||
| ret = MHD_add_response_header(response, MHD_HTTP_HEADER_CONNECTION, "close"); |
Member
There was a problem hiding this comment.
We don't need "Basic realm=XBMC" header?
| return MHD_NO; | ||
|
|
||
| return MHD_get_connection_values(connection, kind, FillArgumentMap, &headerValues); | ||
| return MHD_YES; |
Member
There was a problem hiding this comment.
I don't see headerValues being populated any more. This looks like a bug
| return MHD_NO; | ||
|
|
||
| return MHD_get_connection_values(connection, kind, FillArgumentMultiMap, &headerValues); | ||
| return MHD_YES; |
Member
There was a problem hiding this comment.
Same here: I don't see headerValues being populated
| HandleEvents(); | ||
| if(m_recorder) | ||
| return m_dll->recorder_is_recording(m_recorder) > 0; | ||
| return m_dll->recorder_is_recording(m_recorder) > (void *)0; |
Member
There was a problem hiding this comment.
I've always preferred the implicit conversion of pointers to boolean. E.g.;
return !!m_dll->recorder_is_recording(m_recorder);or
if (CGUIDialogNumeric::ShowAndGetTime(time, heading ? heading : g_localizeStrings.Get(21420)))but this works too ^^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to errors encountered while building with newer deps.