Flyout might be being re-rendered too much

[maribethb]

Check for duplicates

• I have searched for similar issues before opening a new one.

Description

In v12 while testing something else I noticed this warning: Ignoring non-existant field name in block text_append in the console. It occurs many many times as long as the flyout is open. So whatever code that triggers that message is being called way too many times.

In v12 you get the message continuously while the flyout is open.
In v11 you get the message only once per flyout open.

It seems this only happens in the advanced playground, so it might be a bad interaction with the advanced playground and something needs fixing there rather than in core

we should probably not have a non-existent field in the built in block, either, but that seems less pressing.

Reproduction steps

1. Open the advanced playground (not the basic one)
2. Open the Text category of the flyout while the console is open
3. Close it and open it again3.

Stack trace

Screenshots

No response

Browsers

No response

[rachel-fenichel]

Also filed as RaspberryPiFoundation/blockly-keyboard-experimentation#513 in the keyboard experimentation plugin.

[maribethb]

OK, the fact that it's happening in the keyboard experiment as well means it's not just a bad interaction with the advanced playground plugin. Not sure why it doesn't happen in the basic playground though.

[rachel-fenichel]

I also cannot consistently trigger it yet. Specifically, I don't see it on https://insert-connection.blockly-keyboard-experimentation.pages.dev/ but I do see it on https://passive-focus.blockly-keyboard-experimentation.pages.dev/

And on the second one, it still only happens when I navigate past the category and then back up to it. Based on the stack trace (below) it's an issue with the variableChangeCallback and refreshSelection.

Stack trace:

  | Pr | @ | bundle.js:2
-- | -- | -- | --
  | Ar | @ | bundle.js:2
  | xr | @ | bundle.js:2
  | createBlock | @ | bundle.js:2
  | load | @ | bundle.js:2
  | createFlyoutInfo | @ | bundle.js:2
  | show | @ | bundle.js:2
  | refreshSelection | @ | bundle.js:2
  | refreshToolboxSelection | @ | bundle.js:2
  | variableChangeCallback | @ | bundle.js:2
  | fireChangeListener | @ | bundle.js:2
  | B | @ | bundle.js:2
  | setTimeout |   |  
  | (anonymous) | @ | bundle.js:2
  | requestAnimationFrame |   |  
  | F | @ | bundle.js:2
  | j | @ | bundle.js:2
  | dispose | @ | bundle.js:2
  | dispose | @ | bundle.js:2
  | disposeItem | @ | bundle.js:2
  | (anonymous) | @ | bundle.js:2
  | clearOldBlocks | @ | bundle.js:2
  | show | @ | bundle.js:2
  | refreshSelection | @ | bundle.js:2

and as an image: