fix: Visit all nodes in getNextSibling and getPreviousSibling #9080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't work, likely due to isValid check.
RoboErikG
force-pushed
the
line-by-line-navigation
branch
from
4b6788d to
b85247a
Compare
rachel-fenichel
approved these changes
May 21, 2025
Collaborator
|
Merging for Erik since he is OOO tomorrow. |
rachel-fenichel
merged commit e4d7245
into
RaspberryPiFoundation:develop
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes
Proposed Changes
Reason for Changes
Previously you couldn't go from a block connected to a value input to a field on another input. Now you can:
Screen recording 2025-05-21 3.05.51 PM.webm
Test Coverage
Documentation
Additional Information