Remove incorrect SPI setting from BoardEnv.txt #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct way to have SPI is setting "overlays=spidev1_2" and that is already present as an option n othe file. The script was also setting "overlays" at the end of BardoEnv.txt which would smash any "overlays" definition before in the file. It also removes the unnecessary creationof a backup file.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
|
Seems good to me. @jscancella any objections? |
|
Yeah, that won't actually work. Need to use |
Member
|
@joaobarros Are the lines you're referring to commented out? |
Member
|
I need a confirmed working PR that works with ADXL345 (and preferably the BTT SPI screen). Let me know when it's tested! |
|
this is OBE with #74 being merged - recommend closing it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct way to have SPI is setting "overlays=spidev1_2" and that is already present as an option in the file. The script was also setting "overlays" at the end of BardoEnv.txt which would smash any "overlays" definition before in the file. It also removes the unnecessary creationof a backup file.