Display correct unit in Qt wallet transaction history#703
Merged
Conversation
blondfrogs
approved these changes
Dec 6, 2019
Contributor
blondfrogs
left a comment
There was a problem hiding this comment.
utACK - Changes seem fine
Contributor
|
Looks like the AWS ARM build failed to compile the external dependencies. This us a semi-random failure and this PR does not appear to be the cause of the build failure. I restarted and will merge once the builds finish. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Qt wallet transaction history uses 'RVN' for all RVN transactions even if a different display unit is chosen in the options. This has occasionally been a cause of confusion for some users.
These changes: