Fixing broken restricted asset test and loop argument#708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing restricted asset test - it was previously valid to freeze and unfreeze multiple times in one. As of PR #704 this is no longer the case. Now the tests freezes once, and expects assertion on the second attempt.
Also found a problem in the test runner --loop argument. If a test during an early loop fails, it will fail every loop afterwards - This is because the directory structure is not deleted when a test fails (to allow looking at logs etc). The options were to override the directory (would lose any debug info), or to create a new directory - this is what it now does. The test now simply appends a "random" integer to the end of the pathname. This will allow for tests to continue to run with or without error as desired.