Inconsistent state when nested structs update themselves within their own handlers #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A has a nested struct B, B updates itself inside it's own handler, A will have a broken inconsistent state such that
A().B !== A.B()It seems to be caused by event queuing causing the internal state copy to contain an old version and not receiving the new version for reasons.
The fix I wrote simply takes the current value of the nested observable instead of the value passed into the event handler since that value is no longer accurate since the value was updated in the previous listener of that same change event (which is not not re-emitted for reasons, but this is actually somewhat ideal)