remove Rcpp::export tags on lightweight function defs#409
remove Rcpp::export tags on lightweight function defs#409eddelbuettel merged 2 commits intomasterfrom
Conversation
eddelbuettel
left a comment
There was a problem hiding this comment.
Had not thought of that approach either. If that works locally thumbs up!
|
Looks good. I would vote for squash merge and rebase into #404 and can help if needed. |
|
It works: Doing the same on master would produce different exports files. Happy to let you execute squash/merge/rebase/whatever |
|
Yes my 'Looks good' was based on quick checkout of the branch, installing, re-compiling attributes and re-installing. I'll add a quick ChangeLog for you and then proceed. Ok? |
|
Ok -- #404 is now on top of the updated master and the same two commits ahead with the actual change by @klin333 as well as my conditional build (including your removal of the export tag in the one altered file / half). Should be good. And I had forgotten that I had described what I may try next already in #407 |
Addresses #408