Inline Rcpp_list6()
#1049
Merged
Inline Rcpp_list6()
#1049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks. I can assume you tested this R 3.3.* ? (I have some Docker containers here so I could spot check locally too.) I am wondering if we should protect the Edit: Never mind. Should be fine as is. |
Contributor
Author
|
Yea, here is a {yardstick} build that previously failed, but now relies on this PR. Rcpp builds fine on an R 3.3.* build (and 3.2.*). https://github.com/tidymodels/yardstick/runs/514069086?check_suite_focus=true#step:8:97 |
Member
|
"We apologize for any invoncenience caused." Always sorry about breakage but hey, it was your colleague 😎 and we did ask for extensive pre-release tests. But I know how it goes -- CRAN releases just matter more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1048