Skip to content

print.data.table in non-scientific numbers, closes #1167#1276

Merged
arunsrinivasan merged 1 commit intoRdatatable:masterfrom
jangorecki:print_dt_non_scientific
Sep 4, 2015
Merged

print.data.table in non-scientific numbers, closes #1167#1276
arunsrinivasan merged 1 commit intoRdatatable:masterfrom
jangorecki:print_dt_non_scientific

Conversation

@jangorecki
Copy link
Copy Markdown
Member

The PR assumes you agree to have non-scientific notation for row id, which I believe is desired.
I've also made a gap in test( numbers, I skip the 1547 number which I used in PR #1275

@arunsrinivasan
Copy link
Copy Markdown
Member

What's the issue with #353 that you're fixing? The issue #1167 seems to be about two unrelated issues?

Could you issue two PRs, one for each issue in #1167 please?

@jangorecki jangorecki force-pushed the print_dt_non_scientific branch from b443141 to 686a2ec Compare September 3, 2015 00:08
@jangorecki
Copy link
Copy Markdown
Member Author

Separated both issues/PR. This one has a gap in bug fixes sequence, skips number 62. which was used in separated PR for print(., row.names=FALSE).

@jangorecki jangorecki changed the title print.data.table in non-scientific numbers, closes #1167, fixes #353 print.data.table in non-scientific numbers, closes #1167 Sep 3, 2015
@arunsrinivasan arunsrinivasan merged commit 686a2ec into Rdatatable:master Sep 4, 2015
@arunsrinivasan
Copy link
Copy Markdown
Member

Agreed. Easy enough to fallback if need be. Thanks.

@jangorecki jangorecki deleted the print_dt_non_scientific branch February 26, 2016 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants