Skip to content

Fix a regression introduced in #2329#2342

Merged
mattdowle merged 1 commit intoRdatatable:masterfrom
renkun-ken:issue-2326
Sep 8, 2017
Merged

Fix a regression introduced in #2329#2342
mattdowle merged 1 commit intoRdatatable:masterfrom
renkun-ken:issue-2326

Conversation

@renkun-ken
Copy link
Copy Markdown
Member

@renkun-ken renkun-ken commented Sep 8, 2017

Closes #2338

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2342 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2342      +/-   ##
==========================================
+ Coverage   90.92%   91.01%   +0.08%     
==========================================
  Files          61       61              
  Lines       11808    11810       +2     
==========================================
+ Hits        10737    10749      +12     
+ Misses       1071     1061      -10
Impacted Files Coverage Δ
R/data.table.R 97.42% <100%> (ø) ⬆️
src/rbindlist.c 88.74% <0%> (-0.2%) ⬇️
src/forder.c 94.47% <0%> (+0.52%) ⬆️
src/assign.c 94.36% <0%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 405d064...cbf13f1. Read the comment docs.

@mattdowle mattdowle added this to the v1.10.6 milestone Sep 8, 2017
@mattdowle mattdowle merged commit 694d075 into Rdatatable:master Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants