Skip to content

Add test cases for issue 2251#2345

Merged
mattdowle merged 1 commit intomasterfrom
issue2251
Sep 8, 2017
Merged

Add test cases for issue 2251#2345
mattdowle merged 1 commit intomasterfrom
issue2251

Conversation

@st-pasha
Copy link
Copy Markdown
Contributor

@st-pasha st-pasha commented Sep 8, 2017

Commit e79d63b fixed the problem; this PR just adds a test case before the issue can be closed.
Not adding a NEWS.md entry, because the bug was not present in CRAN version

Closes #2251

@st-pasha st-pasha added the fread label Sep 8, 2017
@st-pasha st-pasha added this to the v1.10.6 milestone Sep 8, 2017
@st-pasha st-pasha self-assigned this Sep 8, 2017
@st-pasha st-pasha requested a review from mattdowle September 8, 2017 17:45
@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 8, 2017

Codecov Report

Merging #2345 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2345      +/-   ##
==========================================
- Coverage   91.14%   91.13%   -0.01%     
==========================================
  Files          61       61              
  Lines       11785    11783       -2     
==========================================
- Hits        10742    10739       -3     
- Misses       1043     1044       +1
Impacted Files Coverage Δ
src/rbindlist.c 88.74% <0%> (-0.2%) ⬇️
src/fwrite.c 91.18% <0%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e79d63b...ea7cbaf. Read the comment docs.

Copy link
Copy Markdown
Member

@mattdowle mattdowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thanks!

@mattdowle mattdowle merged commit e704ebe into master Sep 8, 2017
@mattdowle mattdowle deleted the issue2251 branch September 8, 2017 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

colClasses=integer no longer working in fread

3 participants