Skip to content

CRAN patch 1.10.4-2#2415

Merged
mattdowle merged 1 commit intomasterfrom
cran_patch2
Oct 12, 2017
Merged

CRAN patch 1.10.4-2#2415
mattdowle merged 1 commit intomasterfrom
cran_patch2

Conversation

@mattdowle
Copy link
Copy Markdown
Member

Closes #2409

  • ASAN fails fixed
  • Backport base_r order version number to fix fail on oldrel
  • #ifdef out omp_set_num_threads (S.O. report) and added section to CRAN_Release.cmd to catch missing #ifdef _OPENMP in future
  • Updated startup message when no OpenMP since it's no longer correct that OpenMP is not supported by CRAN on Mac

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 12, 2017

Codecov Report

Merging #2415 into master will increase coverage by <.01%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2415      +/-   ##
=========================================
+ Coverage   91.29%   91.3%   +<.01%     
=========================================
  Files          62      62              
  Lines       12027   12028       +1     
=========================================
+ Hits        10980   10982       +2     
+ Misses       1047    1046       -1
Impacted Files Coverage Δ
src/openmp-utils.c 95.65% <ø> (ø) ⬆️
R/onAttach.R 9.09% <0%> (ø) ⬆️
src/rbindlist.c 88.93% <100%> (+0.19%) ⬆️
src/dogroups.c 93.92% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fcaa70...2ba1b5e. Read the comment docs.

@mattdowle mattdowle merged commit b07c28a into master Oct 12, 2017
@mattdowle mattdowle deleted the cran_patch2 branch October 12, 2017 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot install data.table from source due to missing symbol _omp_set_num_threads

3 participants