Skip to content

Remove RVersion.h as a dependency#2467

Merged
mattdowle merged 2 commits intomasterfrom
rversion
Nov 6, 2017
Merged

Remove RVersion.h as a dependency#2467
mattdowle merged 2 commits intomasterfrom
rversion

Conversation

@st-pasha
Copy link
Copy Markdown
Contributor

@st-pasha st-pasha commented Nov 6, 2017

Due to unclear license status of "Rversion.h", I think we'd be better-off not including it (especially since we barely use it at all).

@st-pasha st-pasha self-assigned this Nov 6, 2017
@st-pasha st-pasha requested a review from mattdowle November 6, 2017 18:36
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 6, 2017

Codecov Report

Merging #2467 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2467   +/-   ##
=======================================
  Coverage   91.58%   91.58%           
=======================================
  Files          62       62           
  Lines       12028    12028           
=======================================
  Hits        11016    11016           
  Misses       1012     1012
Impacted Files Coverage Δ
src/quickselect.c 100% <ø> (ø) ⬆️
src/dogroups.c 93.92% <ø> (ø) ⬆️
src/assign.c 94.31% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf3eb5d...560060b. Read the comment docs.

@mattdowle
Copy link
Copy Markdown
Member

Change applied before license change PR #2456

@mattdowle mattdowle merged commit 47b1bbd into master Nov 6, 2017
@mattdowle mattdowle deleted the rversion branch November 6, 2017 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants