Closes #2046 and closes #2111. Fixes -ve length vectors issue with GForce#2480
Merged
Closes #2046 and closes #2111. Fixes -ve length vectors issue with GForce#2480
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2480 +/- ##
==========================================
+ Coverage 91.39% 91.39% +<.01%
==========================================
Files 63 63
Lines 12097 12101 +4
==========================================
+ Hits 11056 11060 +4
Misses 1041 1041
Continue to review full report at Codecov.
|
Member
mattdowle
approved these changes
Jan 15, 2018
Member
mattdowle
left a comment
mattdowle
left a comment
There was a problem hiding this comment.
Moved the fix down to C level to centralize it. Added a double-check to be sure too.
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2046
Closes #2111
Issues related to GForce as explained by @kmillar under #2046 (comment).
Fixed by checking if
maxgrpnattribute is NULL and if so, generating it frommax(len__). Have written in some detail under the fix too.