Skip to content

Skip NUL bytes at the end of the file#2485

Merged
mattdowle merged 3 commits intomasterfrom
fread-nulls
Nov 14, 2017
Merged

Skip NUL bytes at the end of the file#2485
mattdowle merged 3 commits intomasterfrom
fread-nulls

Conversation

@st-pasha
Copy link
Copy Markdown
Contributor

Multiple NUL bytes / 0x1A bytes at the end of the file will be skipped, with a verbose message.

Closes #1895

@st-pasha st-pasha added the fread label Nov 14, 2017
@st-pasha st-pasha added this to the v1.10.6 milestone Nov 14, 2017
@st-pasha st-pasha requested a review from mattdowle November 14, 2017 19:03
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 14, 2017

Codecov Report

Merging #2485 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2485      +/-   ##
==========================================
+ Coverage   91.58%   91.58%   +<.01%     
==========================================
  Files          63       63              
  Lines       12044    12045       +1     
==========================================
+ Hits        11030    11031       +1     
  Misses       1014     1014
Impacted Files Coverage Δ
src/fread.c 96.3% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a90d17e...07c637c. Read the comment docs.

@mattdowle mattdowle merged commit 4a26c33 into master Nov 14, 2017
@mattdowle mattdowle deleted the fread-nulls branch November 14, 2017 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants