fix "broken" R 3.1.0 dependency introduced by failing test 1555.1#2489
Merged
fix "broken" R 3.1.0 dependency introduced by failing test 1555.1#2489
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2489 +/- ##
=======================================
Coverage 91.58% 91.58%
=======================================
Files 63 63
Lines 12046 12046
=======================================
Hits 11032 11032
Misses 1014 1014Continue to review full report at Codecov.
|
jangorecki
approved these changes
Nov 17, 2017
Member
|
Great robust fix @MichaelChirico! |
mattdowle
added a commit
that referenced
this pull request
Nov 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion on #2484; with this minor change,
test.data.table()runs successfully on R 3.1.0