Fixed bug with assignments like DT[,c('x', 'y') := 1:10]#2557
Merged
Fixed bug with assignments like DT[,c('x', 'y') := 1:10]#2557
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2557 +/- ##
==========================================
+ Coverage 91.45% 91.45% +<.01%
==========================================
Files 63 63
Lines 12071 12072 +1
==========================================
+ Hits 11039 11040 +1
Misses 1032 1032
Continue to review full report at Codecov.
|
…as well. Added 753.2 too. Checked these tests fail in current dev and CRAN release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2540
Closes #185
assign.c is very careful, when the right hand side needs to be copied.
However, there was one loophole where it failed to copy the right hand side: if the right hand side is a factory fresh vector, where
MAYBE_SHAREDreturns FALSE, that is assigned to multiple columns.An example is
DT[, c('x', 'y') := 1:10]I fixed and added a test.