Updated NEWS and tests to reflect improved row ordering when joining.#2579
Merged
Updated NEWS and tests to reflect improved row ordering when joining.#2579
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2579 +/- ##
=======================================
Coverage 91.42% 91.42%
=======================================
Files 63 63
Lines 12111 12111
=======================================
Hits 11073 11073
Misses 1038 1038Continue to review full report at Codecov.
|
mattdowle
approved these changes
Jan 23, 2018
Member
There was a problem hiding this comment.
Great.
I ran test in v1.10.4-3 which correctly failed. Works here in dev.
I checked Arun's comments in issue too and looks good: #2559 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2559.
in 1.10.4, the row order after joins was unsexpected sometimes. This has been (accidentally) fixed with PR #2476. Here, we just add a test and a more informative news entry.