Print topn rows properly when class=TRUE (#2803)#2804
Merged
mattdowle merged 3 commits intoRdatatable:masterfrom Apr 28, 2018
Merged
Print topn rows properly when class=TRUE (#2803)#2804mattdowle merged 3 commits intoRdatatable:masterfrom
mattdowle merged 3 commits intoRdatatable:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2804 +/- ##
=======================================
Coverage 93.48% 93.48%
=======================================
Files 61 61
Lines 12365 12365
=======================================
Hits 11560 11560
Misses 805 805
Continue to review full report at Codecov.
|
Member
|
Would you mind adding a test to be sure this behavior doesn't inadvertently revert in the future? There's some pointers on the Contributing page |
heavywatal
added a commit
to heavywatal/data.table
that referenced
this pull request
Apr 29, 2018
Remove extra parentheses in my previous PR Rdatatable#2804
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2803.