Skip to content

as.chron methods removed. Not sure why we had them anyway.#2831

Merged
mattdowle merged 1 commit intomasterfrom
chron
May 4, 2018
Merged

as.chron methods removed. Not sure why we had them anyway.#2831
mattdowle merged 1 commit intomasterfrom
chron

Conversation

@mattdowle
Copy link
Copy Markdown
Member

@mattdowle mattdowle commented May 3, 2018

Closes #2825

NEWS item :

as.chron methods for IDate and ITime have been removed, #2825. as.chron still works since IDate inherits from Date. We are not sure why we had specific methods in the first place. It may have been from a time when IDate did not inherit from Date, perhaps. Note that we don't use chron ourselves in our own work.

I'll rerun rev dep checks before release. If there's any impact I'll think again.

@mattdowle mattdowle added this to the 1.11.2 milestone May 3, 2018
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2831 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2831      +/-   ##
==========================================
+ Coverage   93.45%   93.46%   +<.01%     
==========================================
  Files          61       61              
  Lines       12369    12355      -14     
==========================================
- Hits        11560    11548      -12     
+ Misses        809      807       -2
Impacted Files Coverage Δ
R/IDateTime.R 88.63% <ø> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 401967e...7b1bf80. Read the comment docs.

Copy link
Copy Markdown
Member

@jangorecki jangorecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, another pkg less in suggests :)

@MichaelChirico
Copy link
Copy Markdown
Member

yea the method just looks like a copy job of as.chron.Date.

@mattdowle mattdowle merged commit 12e0f76 into master May 4, 2018
@mattdowle mattdowle deleted the chron branch May 4, 2018 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants