Skip to content

datatable.CJ.names default now TRUE #3053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattdowle merged 1 commit into from
Sep 20, 2018
Merged

datatable.CJ.names default now TRUE #3053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@

**If you are viewing this file on CRAN, please check latest news on GitHub [here](https://github.com/Rdatatable/data.table/blob/master/NEWS.md).**

### Changes in v1.11.7 (in development)
### Changes in v1.11.7 (in development; to be 1.12.0)

#### NEW FEATURES

#### BUG FIXES

#### NOTES

1. The option `datatable.CJ.names` is now TRUE by default as per NEWS item 6 in v1.11.6 (see below). This option will be removed in v1.13.0.


### Changes in v1.11.6 (on CRAN 19 Sep 2018)

Expand Down
2 changes: 1 addition & 1 deletion R/setkey.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ CJ <- function(..., sorted = TRUE, unique = FALSE)
}
setattr(l, "row.names", .set_row_names(length(l[[1L]])))
setattr(l, "class", c("data.table", "data.frame"))
if (getOption("datatable.CJ.names", FALSE)) { # option added v1.11.6. Change to TRUE in v1.12.0
if (getOption("datatable.CJ.names", TRUE)) { # added as FALSE in v1.11.6. Defaul TRUE in v1.12.0. TODO: remove in v1.13.0
vnames = name_dots(...)$vnames
} else {
if (is.null(vnames <- names(l))) vnames = paste0("V", seq_len(length(l)))
Expand Down