Skip to content

Fix one test to pass GL pipeline#3126

Merged
mattdowle merged 1 commit intomasterfrom
forder2
Oct 25, 2018
Merged

Fix one test to pass GL pipeline#3126
mattdowle merged 1 commit intomasterfrom
forder2

Conversation

@mattdowle
Copy link
Copy Markdown
Member

@mattdowle mattdowle commented Oct 25, 2018

follow up to pr #3124
fixed test 1246.55 that failed thanks to one random seed on gitlab pipelines
Added direct test of this case to consistently cover it.

Running test id 1246.54
Running test id 1246.55    
Test 1246.55 ran without errors but failed check that x equals y:
> x = duplicated(DT, by = jj, fromLast = TRUE)
First 6 of 100 (type 'logical'): [1] FALSE FALSE FALSE FALSE FALSE FALSE
> y = duplicated.data.frame(DT[, jj, with = FALSE], fromLast = TRUE)
First 6 of 100 (type 'logical'): [1] FALSE FALSE FALSE FALSE FALSE FALSE
1 element mismatch
Running test id 1246.56
Running test id 1246.57
Running test id 1246.58
Running test id 1246.59
Running test id 1246.6
forder decreasing argument test: seed = 1540402216  colorder = 4,2,3,1colorder = 2,4,3,1
Running test id 1247.1

also simplified dtwiddle()

@mattdowle mattdowle added this to the 1.12.0 milestone Oct 25, 2018
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 25, 2018

Codecov Report

Merging #3126 into master will decrease coverage by <.01%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3126      +/-   ##
==========================================
- Coverage   91.96%   91.95%   -0.01%     
==========================================
  Files          61       61              
  Lines       11434    11437       +3     
==========================================
+ Hits        10515    10517       +2     
- Misses        919      920       +1
Impacted Files Coverage Δ
src/forder.c 98.93% <93.75%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e59ba14...5fe0d91. Read the comment docs.

@mattdowle mattdowle merged commit 9935f2d into master Oct 25, 2018
@mattdowle mattdowle deleted the forder2 branch October 25, 2018 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant