Skip to content

shift now accept type="shift" for more intuitive give.names=T output,…#3226

Merged
mattdowle merged 2 commits intomasterfrom
shift-type-shift
Dec 20, 2018
Merged

shift now accept type="shift" for more intuitive give.names=T output,…#3226
mattdowle merged 2 commits intomasterfrom
shift-type-shift

Conversation

@jangorecki
Copy link
Copy Markdown
Member

closes #3223

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 15, 2018

Codecov Report

Merging #3226 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3226      +/-   ##
==========================================
- Coverage   94.65%   94.64%   -0.01%     
==========================================
  Files          65       65              
  Lines       12076    12077       +1     
==========================================
  Hits        11430    11430              
- Misses        646      647       +1
Impacted Files Coverage Δ
src/shift.c 99.15% <100%> (ø) ⬆️
R/shift.R 88.88% <100%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87e48f0...a3a9a21. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 15, 2018

Codecov Report

Merging #3226 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3226      +/-   ##
==========================================
+ Coverage   94.65%   94.65%   +<.01%     
==========================================
  Files          65       65              
  Lines       12076    12098      +22     
==========================================
+ Hits        11430    11451      +21     
- Misses        646      647       +1
Impacted Files Coverage Δ
src/shift.c 99.15% <100%> (ø) ⬆️
R/shift.R 93.75% <100%> (-6.25%) ⬇️
R/foverlaps.R 100% <0%> (ø) ⬆️
src/subset.c 100% <0%> (ø) ⬆️
src/assign.c 94.66% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87e48f0...32eee2b. Read the comment docs.

@mattdowle mattdowle added this to the 1.12.0 milestone Dec 20, 2018
@mattdowle mattdowle merged commit 6e60d7b into master Dec 20, 2018
@mattdowle mattdowle deleted the shift-type-shift branch December 20, 2018 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

shift better naming for negative n

2 participants