Skip to content

merge retains custom classes of first argument#3265

Merged
mattdowle merged 3 commits intomasterfrom
merge-class
May 31, 2019
Merged

merge retains custom classes of first argument#3265
mattdowle merged 3 commits intomasterfrom
merge-class

Conversation

@jangorecki
Copy link
Copy Markdown
Member

@jangorecki jangorecki commented Jan 10, 2019

closes #1378,
also changed use of nomatch=0L to nomatch=NULL

@jangorecki jangorecki added this to the 1.12.2 milestone Jan 10, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 10, 2019

Codecov Report

Merging #3265 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3265      +/-   ##
==========================================
+ Coverage   98.19%   98.19%   +<.01%     
==========================================
  Files          66       66              
  Lines       12922    12923       +1     
==========================================
+ Hits        12689    12690       +1     
  Misses        233      233
Impacted Files Coverage Δ
R/merge.R 98.5% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93789ff...4b83d3f. Read the comment docs.

@jangorecki jangorecki modified the milestones: 1.12.2, 1.12.4 Jan 22, 2019
@mattdowle mattdowle changed the title merge retains class of first argument, closes #1378 merge retains custom classes of first argument May 31, 2019
@Rdatatable Rdatatable deleted a comment from codecov bot May 31, 2019
@mattdowle mattdowle merged commit 421f672 into master May 31, 2019
@mattdowle mattdowle deleted the merge-class branch May 31, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

merge can't handle custom classes

2 participants