Foverlaps bug fix for overlapping on POSIXct objects < 1970-01-01#3382
Merged
Foverlaps bug fix for overlapping on POSIXct objects < 1970-01-01#3382
Conversation
Member
Author
|
@mattdowle added you just to make sure I've created the PR as expected. Committing after a while .. |
Codecov Report
@@ Coverage Diff @@
## master #3382 +/- ##
==========================================
- Coverage 95.09% 95.09% -0.01%
==========================================
Files 65 65
Lines 12122 12120 -2
==========================================
- Hits 11528 11526 -2
Misses 594 594
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3382 +/- ##
==========================================
- Coverage 95.09% 95.09% -0.01%
==========================================
Files 65 65
Lines 12122 12120 -2
==========================================
- Hits 11528 11526 -2
Misses 594 594
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
foverlaps returned incorrect results when overlapping on POSIXct dates with datetime values < 1970-01-01. closes #3349