Skip to content

dcast handles fun.aggregate argument better#3384

Merged
mattdowle merged 5 commits intomasterfrom
issue-1369-2949-1974-dcast
Feb 15, 2019
Merged

dcast handles fun.aggregate argument better#3384
mattdowle merged 5 commits intomasterfrom
issue-1369-2949-1974-dcast

Conversation

@arunsrinivasan
Copy link
Copy Markdown
Member

@arunsrinivasan arunsrinivasan commented Feb 10, 2019

Closes #2949, closes #1974 and closes #1369. All are identical issues more or less.

MichaelChirico
MichaelChirico reviewed Feb 10, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@MichaelChirico MichaelChirico left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Since #1974 is mentioned but closed already as a dupe, maybe reference #2064 as well?

@arunsrinivasan
Copy link
Copy Markdown
Member Author

arunsrinivasan commented Feb 10, 2019

Hm will check why it is failing and update

@arunsrinivasan
Copy link
Copy Markdown
Member Author

arunsrinivasan commented Feb 10, 2019

Not yet done. Will update ASAP. My dev env tests didn't run my tests due to data.table library being loaded and I somehow skipped that.

@mattdowle mattdowle added this to the 1.12.2 milestone Feb 11, 2019
@jangorecki
Copy link
Copy Markdown
Member

jangorecki commented Feb 12, 2019

I pushed some fixes to pass newly added unit tests. One of them has been turned to check.attributes=FALSE because column names does not match when list(sum, mean) is passed to dcast, as names of the functions are not detected, only their body.
Anyway my fix here broke 1700.1

@arunsrinivasan
Copy link
Copy Markdown
Member Author

arunsrinivasan commented Feb 15, 2019 •
edited
Loading

Should be all done now.. hopefully. Feel free to squash while merging.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 15, 2019 •
edited
Loading

Codecov Report

Merging #3384 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3384      +/-   ##
=========================================
- Coverage   95.11%   95.1%   -0.01%     
=========================================
  Files          65      65              
  Lines       12118   12126       +8     
=========================================
+ Hits        11526   11533       +7     
- Misses        592     593       +1
Impacted Files Coverage Δ
R/fcast.R 90.32% <100%> (+0.37%) ⬆️
R/data.table.R 97.47% <100%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e223fab...937d820. Read the comment docs.

@mattdowle mattdowle merged commit 28e31f5 into master Feb 15, 2019
@mattdowle mattdowle deleted the issue-1369-2949-1974-dcast branch February 15, 2019 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelChirico MichaelChirico MichaelChirico left review comments

@jangorecki jangorecki jangorecki approved these changes

@mattdowle mattdowle Awaiting requested review from mattdowle

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.12.2

4 participants

@arunsrinivasan @jangorecki @MichaelChirico @mattdowle